Fixed a terrible diff issue case of PostgreSQL - Githubissues

dbsrgits / sql-translator

SQL::Translator (SQLFairy)

http://sqlfairy.sourceforge.net/

82 stars 91 forks source link

Fixed a terrible diff issue case of PostgreSQL #91

Closed Code-Hex closed 2 years ago

Code-Hex commented 7 years ago

Why terrible?

It outputs syntax that will result in an error when executed. ALTER TABLE tablename ALTER colname TYPE serial;
When parsing from DBI, unexpected types are returned
Similarly, unexpected sizes are returned
There is no type match for time

What I did?

I rewrote SQL to solve the above problem.
Added a dedicated parser statement for smallserial.
When type like serial, we modified it to use CREATE SEQUENCE instead of ALTER.

Best regard 👍