Infer the node name from the unique_id - Githubissues

dbt-labs / dbt-adapter-tests

a pytest plugin for dbt adapter test suites

19 stars 11 forks source link

Infer the node name from the unique_id #10

Closed dbeatty10 closed 3 years ago

dbeatty10 commented 3 years ago

resolves #9

Description

Infer the node name from the unique_id (to support changes introduced in dbt 0.19.0).

The maintainers will need to determine how the version of this package will need to be bumped if this PR is accepted.

I'm guessing this entry from the CHANGELOG is where the breaking changes came from:

Rationalize run result status reporting and clean up artifact schema (#2493, #2943)

Pros

minimal set of changes to achieve passing tests

Cons

someone might have a more comprehensive vision for altering how names and attributes might work in 0.19.0+

Caveats

I didn't test this pull request against any dbt versions other than 0.19.0rc1 (or databases other than Postgres)
depending on compatibility with versions earlier than 0.19.0rc1, either the dbt-adapter-tests version will need to be bumped or a different strategy will need to be taken

Checklist

[X] I have signed the CLA
[X] I have run this code in development and it appears to resolve the stated issue
[X] This PR includes tests, or tests are not required/relevant for this PR

kwigley commented 3 years ago

thanks @dbeatty10! I went ahead and merged this in order to cut v0.4.0 👍