search

dbt-labs / dbt-adapter-tests

a pytest plugin for dbt adapter test suites
19 stars 11 forks source link

Not fully compatible with dbt-core 0.19.0rc1 #9

Closed dbeatty10 closed 3 years ago

dbeatty10 commented 3 years ago

Describe the bug

Two test specifications within dbt-adapter-tests aren't compatible with dbt-core 0.19.0rc1:

Steps To Reproduce

  1. Install dbt 0.19.0rc1
  2. Create a test configuration for Postgres
    • see below for an example *.dbtspec file
  3. Run the test config
    • with a command like pytest -v test/integration/postgres-13.dbtspec

test/integration/postgres-13.dbtspec example

target:
  type: postgres
  host: localhost
  user: postgres
  pass: ********************
  port: 5432
  dbname: postgres
  schema: dbt_test_{{ var('_dbt_random_suffix') }}

sequences:
  test_dbt_data_test: data_test
  test_dbt_ephemeral_data_tests: data_test_ephemeral_models

Expected behavior

I expected all the standard tests to pass for dbt-postgres v0.19.0rc1 (since it is a Fishtown-supported database adapter).

Screenshots and log output

Log output (drastically truncated):

_________________________________________________________ usecase: test_dbt_data_test __________________________________________________________
usecase execution failed
   spec failed: ("Invalid result, missing required key 'node'",)
   no further details known at this point.
------------------------------------------------------------- Captured stdout call -------------------------------------------------------------

(snip)

test/integration/postgres-13.dbtspec::test_dbt_data_test FAILED
test/integration/postgres-13.dbtspec::test_dbt_ephemeral_data_tests FAILED

System information

Which database are you using dbt with?

Although I only tested this against Postgres, I would expect this same problem to affect all the databases supported by Fishtown Analytics as well as all community-supported plugins.

The output of dbt --version:

installed version: 0.19.0-rc1
   latest version: 0.18.1

Your version of dbt is ahead of the latest release!

Plugins:
  - postgres: 0.19.0rc1

Additional context

I've got a simple workaround that I'll submit as a pull request.