dbt-labs / dbt-adapters

Apache License 2.0
17 stars 20 forks source link

[Feature] Test for `date_spine` should use a minimal date range #208

Open dbeatty10 opened 2 months ago

dbeatty10 commented 2 months ago

Housekeeping

Short description

The date range within fixture_date_spine.py is larger than needed.

Context

This doesn't affect the correctness of the test, but it does affect it's readability.

The test would be more readable with a minimal date range.

History: this test was migrated effectively as-is from dbt-utils to dbt-core to dbt-adapters. But now we'll probably want to clean it up a bit.

Acceptance criteria

- [ ] The date range is no more than 3 days
- [ ] Optional: the date range spans a month (or year) boundary (e.g. `1999-12-31` to `2000-01-03`)
- [ ] Optional: the date range spans includes a leap day (e.g. `2024-02-28` to `2024-03-02`)

Testing

See acceptance criteria above.

Security

No security concerns.

Docs

No doc updates needed.

Consequences

This change impacts any adapter that imports this test. But it doesn't change the essence of the test and will effectively be a no-op.