The test for the cross-adapter date_spine macro within fixture_date_spine.py contains adapter-specific logic like {% if target.type == 'postgres' %} that should be in dbt-postgres instead.
Context
History: this test was migrated effectively as-is from dbt-utils to dbt-core to dbt-adapters. But now we'll probably want to clean it up a bit.
Acceptance criteria
- [ ] The test definition in `dbt-adapters` contains no adapter-specific logic like `{% if target.type == 'postgres' %}`
- [ ] Rather, adapters like `dbt-postgres` can override the test as-needed
Testing
- [ ] Test in `dbt-postgres`
- [ ] Test in `dbt-bigquery`
- [ ] Test in `dbt-redshift`
- [ ] Test in `dbt-snowflake`
- [ ] Test in `dbt-spark`
Security
No security concerns.
Docs
No doc updates needed.
Consequences
This change impacts any adapter that imports this test.
Depending on the final implementation in dbt-adapters, the adapter types that are currently hard-coded (postgres, bigquery, redshift) may need to provide overrides of the text fixtures as a result of this change.
Housekeeping
dbt-adaptersShort description
The test for the cross-adapter
date_spinemacro withinfixture_date_spine.pycontains adapter-specific logic like{% if target.type == 'postgres' %}that should be indbt-postgresinstead.Context
History: this test was migrated effectively as-is from dbt-utils to dbt-core to dbt-adapters. But now we'll probably want to clean it up a bit.
Acceptance criteria
Testing
Security
No security concerns.
Docs
No doc updates needed.
Consequences
This change impacts any adapter that imports this test.
Depending on the final implementation in
dbt-adapters, the adapter types that are currently hard-coded (postgres,bigquery,redshift) may need to provide overrides of the text fixtures as a result of this change.