Avoid false positives in `date_spine` macro - Githubissues

dbt-labs / dbt-adapters

Apache License 2.0

17 stars 20 forks source link

Avoid false positives in `date_spine` macro #211

Open dbeatty10 opened 2 months ago

dbeatty10 commented 2 months ago

resolves https://github.com/dbt-labs/dbt-adapters/issues/210 resolves https://github.com/dbt-labs/dbt-adapters/issues/208

Problem

While working on https://github.com/dbt-labs/dbt-core/issues/10075, I noticed a few things about this test case:

The date range is larger than needed
The test can give a false positives
There are hard-coded adapter types

The second one is the most impactful. This PR solves the first two.

Solution

Reduce the date range from 9 down to 3 (which gets rid of 36 lines of code)
Use a full outer join rather than a left join to eliminate possibility of a false positive

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development, and it appears to resolve the stated issue
[x] New tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.)