dbt-labs / dbt-adapters

Apache License 2.0
28 stars 38 forks source link

[CT-3254] Remove hard-coded adapter logic from tests for `date_spine` macros #223

Open dbeatty10 opened 1 year ago

dbeatty10 commented 1 year ago

Housekeeping

Short description

@jwills asked within https://github.com/dbt-labs/dbt-core/discussions/8307#discussioncomment-7373642 if we can make it easier for adapter maintainers to specify their preferred date format within the tests for date_spine and supporting macros.

Currently, there is hardcoding of target.type == 'postgres' etc. whose logic that we want in adapter implementations rather than in dbt-core.

Acceptance criteria

Impact to Other Teams

This change directly affects dbt-bigquery, dbt-postgres, and dbt-redshift that may need to accommodate any change. The appropriate Impact: Adapters label has been added.

Will backports be required?

Backport to 1.7.latest. The backport 1.7.latest label has been added.

Context

See dbt-labs/dbt-core#8172, dbt-labs/dbt-core#8616, and https://github.com/dbt-labs/dbt-core/discussions/8307#discussioncomment-7373642 for background context.

See dbt-labs/dbt-adapters#192 for proposed cross-database to_date macro that is intended to make test customization on a per-adapter basis either completely unnecessary or exceedingly rare.

jtcohen6 commented 5 months ago

Moving to dbt-adapters since the relevant tests have also moved there: