dbt-labs / dbt-adapters

Apache License 2.0
25 stars 35 forks source link

[CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation #256

Open McKnight-42 opened 3 months ago

McKnight-42 commented 3 months ago

resolves #250 docs dbt-labs/docs.getdbt.com/#

Problem

Try to fix issue around case sensitive column quoting in macro default__alter_relation_add_remove_columns

Solution

update the dbt-adapters default implementation test against postgres and other adapted as needed to maintain compaitiablity, update dbt-snowflake implementation of macro

create test in dbt-tests-adapters and inherit in adapters as needed.

Checklist

github-actions[bot] commented 3 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

McKnight-42 commented 3 months ago

NOTES: usage across adapters

Adapters that use own implementation of alter_relation_add_remove_columns (defined in dot-adapters)

Adapters that would use default if at all (not referenced in either adapter directly)