Closed mikealfare closed 2 weeks ago
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.
Do we need to update this one too? https://github.com/dbt-labs/dbt-adapters/blob/bug/213-fix-empty-flag/dbt/include/global_project/macros/materializations/tests/where_subquery.sql#L9
I'm honestly not sure. Based on where this macro is, I assume it's used in the test materialization. However, I don't see where this macro is called. I looked in both dbt-adapters
and dbt-snowflake
and there's no reference outside of defining the macro. Either way, I think we'd want to limit the results here just like we would in other materializations. It also doesn't create invalid sql like it does in describe
/show
queries. I can add it if you feel otherwise, but I'm inclined to leave this as is.
resolves #213
Problem
We fixed
dbt-snowflake
when using--empty
and running metadata queries.Solution
Add the tests for that fix so other adapters can use it if necessary.
Implementation
dbt-tests-adapter
(we`re here)dbt-tests-adapter
testsChecklist