Previously we were adding microbatch to the list of builtin_incremental_strategies only when the behavior flag require_batched_execution_for_custom_microbatch_strategy was set to True. However in reality, we only want to set it True when that flag evaluates to False. This is because having the flag set to True implies by the transitive property that the project has a custom microbatch macro defined. In this situation, we don't want microbatch to be in the list of builtins because if the adapter doesn't have a builtin microbatch macro, things will break. Said another way, the only time that having microbatch in the list of builtin incremental strategies is relevant is when the flag is False.
Solution
Only add microbatch to the list of builtin_incremental_strategies when the behavior flag require_batched_execution_for_custom_microbatch_strategy is False
[X] I have run this code in development, and it appears to resolve the stated issue
[X] This PR includes tests, or tests are not required/relevant for this PR
[X] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX
resolves #349
Problem
Previously we were adding
microbatch
to the list ofbuiltin_incremental_strategies
only when the behavior flagrequire_batched_execution_for_custom_microbatch_strategy
was set to True. However in reality, we only want to set it True when that flag evaluates to False. This is because having the flag set to True implies by the transitive property that the project has a custom microbatch macro defined. In this situation, we don't wantmicrobatch
to be in the list ofbuiltins
because if the adapter doesn't have a builtinmicrobatch
macro, things will break. Said another way, the only time that havingmicrobatch
in the list of builtin incremental strategies is relevant is when the flag is False.Solution
Only add
microbatch
to the list ofbuiltin_incremental_strategies
when the behavior flagrequire_batched_execution_for_custom_microbatch_strategy
isFalse
Checklist