Open svdimchenko opened 11 months ago
I tend to be in favour of 1 or 3. 3 will be the hardest but the most future-proof solution while 1 is easier to put in place and keeps things ordered and separated. :)
I believe that 1 and 3 are quite similar.
I like the idea suggested on the 1, docs
are centrally defined in dbt-athena
with a github action that keeps dbt-athena.github.io in sync. Bare in mind that to use github pages you need a repo like dbt-athena.github.io
, therefore 3 might not be really possible.
Ok so let's go with solution 1:
Add docs directory to dbt-athena repo and push changes from there to dbt-athena.github.io on changes
here is pipeline example I've just found which is pretty similar to what we need: https://github.com/marcosschroh/dc-avro/blob/master/.github/workflows/docs-publish.yaml
@nicor88 @Jrmyy As we’ve chosen the way to push docs, I see 2 options:
@svdimchenko I believe that option 2 is could be better. Now let's pick up a real case scenario, to highlight what needs to be done:
Does the flow above make sense or I missed something? If so, can our magic docs update github action work as described above?
Problem statement: currently we must support 2 similar docs sites: readme file in
dbt-athena
repo and https://github.com/dbt-athena/dbt-athena.github.io, it's not so convenient and may lead to docs inconsistent state.Possible options may be following:
docs
directory todbt-athena
repo and push changes from there todbt-athena.github.io
on changesdbt-athena.github.io
side somehowdbt-athena
and deprecatedbt-athena.github.io
(It may be not the optimal solution due to site deployment extra work needed)