search

dbt-labs / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
https://dbt-athena.github.io
Apache License 2.0
228 stars 100 forks source link

feat: Allow different schema for tmp tables created during table materialization #664

Open pierrebzl opened 5 months ago

pierrebzl commented 5 months ago

Description

As described in https://github.com/dbt-athena/dbt-athena/issues/662, this intend to extend temp_schema option table materialization that requires to create transient temporary tables.

After this PR, with temp_schema set on all your models that use table maaterialization, you should not see any tmp tables created inside model target schemas.

Models used to test - Optional

Checklist

nicor88 commented 5 months ago

@pierrebzl is this ready for review? If so we can move it from the draft state, and I can start to review it.

pierrebzl commented 5 months ago

@pierrebzl is this ready for review? If so we can move it from the draft state, and I can start to review it.

Yes, sorry I was away for the past 2 weeks. Yes, this part is RFR but I don't think it covers all the use case of temp table creation yet.

svdimchenko commented 5 months ago

functional test seems to be failed, pls take a look there