search

dbt-labs / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
https://dbt-athena.github.io
Apache License 2.0
228 stars 100 forks source link

chore: Update dbt-tests-adapter requirement from ~=1.8.0 to ~=1.9.1 #673

Closed dependabot[bot] closed 5 months ago

dependabot[bot] commented 5 months ago

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
nicor88 commented 5 months ago

@svdimchenko not sure what it's wrong here, but somehow I'm keeping getting:

FAILED tests/functional/adapter/test_retries_iceberg.py::TestIcebergRetriesDisabled::test__retries_iceberg - AssertionError: dbt exit state did not match expected = 1 failed, 89 passed, 18 skipped, 1 xfailed, 83 warnings in 440.22s (0:07:20)

I've seen this error also in the main branch. Any clue on how can we tweak those functional tests?

nicor88 commented 5 months ago

@svdimchenko https://github.com/dbt-athena/dbt-athena/pull/674 seems that resolved the issue.