dbt-labs / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
https://dbt-athena.github.io
Apache License 2.0
228 stars 100 forks source link

[Bug] No query-comment on CREATE TABLE statement #701

Closed sanromeo closed 3 months ago

sanromeo commented 3 months ago

Is this a new bug in dbt-athena?

Current Behavior

No query-comment on CREATE TABLE statement Query example:

create table "awsdatacatalog"."sandbox_roman_korsun"."test1"
    with (
      table_type='iceberg',
      is_external=false,location='s3://location'
      format='parquet',
      vacuum_max_snapshot_age_seconds=86400
    )
    as
      select 1 as test_column

Expected Behavior

query-comment exists in CREATE TABLE query:

create table "awsdatacatalog"."sandbox_roman_korsun"."test1"
    with (
      table_type='iceberg',
      is_external=false,location='s3://location'
      format='parquet',
      vacuum_max_snapshot_age_seconds=86400
    )
    as
      select 1 as test_column
-- /* {"app": "dbt", "dbt_version": "1.8.1", "profile_name": "athena", "target_name": "local", "dag_id": "UNKNOWN", "dag_run_id": "UNKNOWN", "task_id": "UNKNOWN"  */

Steps To Reproduce

Run model with vacuum_max_snapshot_age_seconds parameter included

Environment

- OS: MacOS 
- Python: 3.11.7
- dbt: 1.8.1
- dbt-athena-community: 1.8.3

Additional Context

No response