search

dbt-labs / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
https://dbt-athena.github.io
Apache License 2.0
228 stars 100 forks source link

chore: Update dbt-tests-adapter requirement from ~=1.9.2 to ~=1.10.1 #721

Closed dependabot[bot] closed 1 month ago

dependabot[bot] commented 2 months ago

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

nicor88 commented 1 month ago

@colin-rogers-dbt sometimes functional tests due to:

FAILED tests/functional/adapter/test_retries_iceberg.py::TestIcebergRetriesDisabled::test__retries_iceberg - AssertionError: dbt exit state did not match expected = 1 failed, 97 passed, 18 skipped, 1 xfailed, 114 warnings in 407.52s (0:06:47) =

Specifically, there is a function test that checks if ICEBERG retry COMMIT feature works as expected, and I've seen that test randomly falling - just retrigger the CI manaully. If the test is becoming annoying, we can consider removing it or increasing the retries number to a higher value.

dependabot[bot] commented 1 month ago

A newer version of dbt-tests-adapter exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

mikealfare commented 1 month ago

This requirement moved. It will be easier to update the dependabot config and have a new PR.

dependabot[bot] commented 1 month ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.