search

dbt-labs / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
https://dbt-athena.github.io
Apache License 2.0
228 stars 100 forks source link

[Bug] dbt docs shown not actual iceberg columns #726

Closed nicor88 closed 1 month ago

nicor88 commented 1 month ago

Is this a new bug in dbt-athena?

Current Behavior

When generating catalog.json via dbt docs, if an Iceberg table has a column that's being dropped, the column is still shown in the catalog.json. Iceberg tables keep track of not actual column via the property iceberg.field.current, that should be used to exclude not current columns.

Expected Behavior

Dropped columns for iceberg tables are not shown.

Steps To Reproduce

  1. Create an iceberg table
  2. Manually drop a column
  3. Generate dbt docs

Environment

- OS:
- Python:
- dbt:
- dbt-athena-community: 1.8.2

Additional Context

https://github.com/dbt-labs/dbt-athena/pull/189/files

nicor88 commented 1 month ago

This issue was addressed by https://github.com/dbt-labs/dbt-athena/pull/731