dbt-labs / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)
https://dbt-athena.github.io
Apache License 2.0
228 stars 100 forks source link

fix: increase iceberg retries in integration tests #746

Closed nicor88 closed 3 weeks ago

nicor88 commented 1 month ago

Description

The iceberg retries integration test is the most problematic. Sometimes, it passes, and sometimes, it does not. Currently the test dues 10 parallel inserts. The idea of this PR is to increase num_iceberg_retries to a value big enough, to allow the test to pass.

Checklist

nicor88 commented 1 month ago

@mikealfare @colin-rogers-dbt FYI.

nicor88 commented 1 month ago

Input required and not supplied: aws-region

Integration tests seem to be failing because there is a missing region @mikealfare

I believe that the issue is because here, my user (and every other user that contribute) don't have access to the variable. If the variable is set on your organization level, I cannot certenly use it. But if the variable is set on the repo level, I should be able to use it - as it used to be in the old dbt-athena repo.

mikealfare commented 1 month ago

Input required and not supplied: aws-region

Integration tests seem to be failing because there is a missing region @mikealfare

I believe that the issue is because here, my user (and every other user that contribute) don't have access to the variable. If the variable is set on your organization level, I cannot certenly use it. But if the variable is set on the repo level, I should be able to use it - as it used to be in the old dbt-athena repo.

The region is there. This looks like it's related to the aws-creds action. It started failing for me after last night for v2, but v4 passes. I have another PR that was affectd that has that fix. So when I get that merged in, I'll sync this PR and all should be fine

nicor88 commented 4 weeks ago

@mikealfare any updates here? Integrations tests seems still not working, even after merging the latest from the main branch

mikealfare commented 4 weeks ago

Turning it off and on again