dbt-labs / dbt-athena

The athena adapter plugin for dbt (https://getdbt.com)

https://dbt-athena.github.io

Apache License 2.0

228 stars 100 forks source link

Invalid tmp table name when using: unique_tmp_table_suffix #754

Open atommych opened 1 week ago

atommych commented 1 week ago

Description

When using unique_tmp_table_suffix=True, the UUID added generated contain dashes which causes the following error: mismatched input '-'. Expecting: '(', '.', 'AS', 'COMMENT', 'WITH'

Checklist

[x] You followed contributing section
[x] You kept your Pull Request small and focused on a single feature or bug fix.
[x] You added unit testing when necessary
[x] You added functional testing when necessary

nicor88 commented 1 week ago

@atommych could you have a look at the interagration tests? They might need to be readapted

nicor88 commented 1 day ago

@atommych any plan to fix the integration tests? I believe that this regex must be re-adapted to omit the -, also if it's easier, we could consider to use replace('-','_') then in the regex for the integration tests we can simply replace the - with _. Using _ in the table name is still valid.

atommych commented 1 day ago

Hi @nicor88 , I will work on it till Friday! Thanks for the tips