dbt-labs / dbt-audit-helper

Useful macros when performing data audits
https://hub.getdbt.com/dbt-labs/audit_helper/latest/
Apache License 2.0
329 stars 40 forks source link

remove internal macro and todo from readme #71

Closed leoebfolsom closed 1 year ago

leoebfolsom commented 1 year ago

Closes #64

Description & motivation

This PR addresses two separate issues:

Note that I explained the context of compare_column_values_verbose in this comment.

tl;dr is that I'm hoping we can keep it as an internal macro to make the code easier to understand; but regardless, it should be removed from the readme to reduce readme overwhelm. compare_column_values_verbose is an internal macro used by another macro in the package itself, and doesn't really need to be exposed to the user (and certainly not in the readme).

Checklist

leoebfolsom commented 1 year ago

@graciegoheen I'm not sure if I'm able to officially request a review, but I thought you might want to see this one and avoid any duplicate efforts 🙏