Fix group by in compare_column_values

dbt-labs / dbt-audit-helper

Useful macros when performing data audits

https://hub.getdbt.com/dbt-labs/audit_helper/latest/

Apache License 2.0

329 stars 40 forks source link

Fix group by in compare_column_values #88

Closed evabilski closed 5 months ago

evabilski commented 1 year ago

Description & motivation

Grouping by aliases does not seem to be permitted in SQL standard Fix https://github.com/dbt-labs/dbt-audit-helper/issues/87

Checklist

[x] I have verified that these changes work locally
~~I have updated the README.md (if applicable)~~
~~I have added tests & descriptions to my models (and macros if applicable)~~

github-actions[bot] commented 6 months ago

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] commented 5 months ago

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

allandsouza commented 4 months ago

Looks like the fix for this was in place but couldn't be reviewed/merged? I am wondering what the process is to revive this PR. thoughts?