search

dbt-labs / dbt-bigquery

dbt-bigquery contains all of the code required to make dbt operate on a BigQuery database.
https://github.com/dbt-labs/dbt-bigquery
Apache License 2.0
210 stars 149 forks source link

Change log level to INFO for the BigQuery job link #1328

Open pankajkoti opened 2 weeks ago

pankajkoti commented 2 weeks ago

Is this your first time submitting a feature request?

Describe the feature

Currently I see that the job link log output is set to debug level. It would really help users have this job link printed always to have quick lookups of the job in BigQuery. I believe it's currently set to debug looking at here https://github.com/dbt-labs/dbt-bigquery/blob/de2bca1c9030754f8fd981ae736206f05046f6f7/dbt/adapters/bigquery/connections.py#L795

Describe alternatives you've considered

No response

Who will this benefit?

Most users who would like to have the link visible in the logs for the submitted BQ job

Are you interested in contributing this feature?

Yes, I have not yet contributed, but maybe sometime soon if no else picks up until then.

Anything else?

Also want to validate if there are any reservations on changing the log level to info from the current debug level

amychen1776 commented 2 weeks ago

Hi @pankajkoti at this time, we do not have capacity to tackle this on our roadmap but would always welcome a pull request :) I should also flag if you look into it, does it change the level of permissioning needed to execute of which we would want to be cautious.

pankajkoti commented 2 weeks ago

does it change the level of permissioning needed to execute of which we would want to be cautious.

hi @amychen1776 thanks for the quick response. Could you throw some more light on how it depends on permissions if we would have to change just the log level?

amychen1776 commented 2 weeks ago

@pankajkoti I was thinking in terms of if you need any additional permissioning in order to access the metadata tables in order to get the job link as well as for folks who want to click on the job link. It seems like there are some conversations on StackOverflow about that (when I did my high level research into what job links are)