Catch google `NotFound` exception as a `DbtDatabaseError`

mikealfare commented 1 month ago

Problem

We were not catching a database exception and then returning the result as a runtime exception. This was caught in a test that was recently updated to expect a database exception. The functionality that changed used to not run this code at all, hence it used to pass.

Solution

Add another condition for catching database exceptions.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

github-actions[bot] commented 1 month ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

github-actions[bot] commented 1 month ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

dbt-labs / dbt-bigquery