dbt-labs / dbt-bigquery

dbt-bigquery contains all of the code required to make dbt operate on a BigQuery database.
https://github.com/dbt-labs/dbt-bigquery
Apache License 2.0
210 stars 149 forks source link

[Feature] Align dbt-bigquery with dbt-core third party dependencies #709

Closed Dizzyobeah closed 10 months ago

Dizzyobeah commented 1 year ago

Is this your first time submitting a feature request?

Describe the feature

Hi,

Latest versions of Google Cloud Composer comes with agate 1.7.0 preinstalled. This prevents us from installing dbt-bigquery since the requirement is agate 1.6.3. If possible please align agate version with that of dbt-core (1.6.3-1.7.0).

Describe alternatives you've considered

Use an earlier version of Google Cloud Composer where agate 1.6.3 is installed as trying to resolve all other dependencies in a pre-built solution is not to recommend.

Who will this benefit?

Everyone using Google Cloud Composer and need to run later versions.

Are you interested in contributing this feature?

No response

Anything else?

https://cloud.google.com/composer/docs/concepts/versioning/composer-versions

dbeatty10 commented 1 year ago

Thanks for reporting this @Dizzyobeah !

dbt-bigquery got its own agate dependency added in https://github.com/dbt-labs/dbt-bigquery/pull/458, but I'm not sure why.

We could try deleting this line and see if it passes CI: https://github.com/dbt-labs/dbt-bigquery/blob/f717e83927e5ac71c4a085985ecc95e7c0c70099/setup.py#L81

github-actions[bot] commented 10 months ago

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

github-actions[bot] commented 10 months ago

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.