Add `include_data_types` argument to `generate_model_yaml` macro

dbt-labs / dbt-codegen

Macros that generate dbt code

https://hub.getdbt.com/dbt-labs/codegen/latest/

Apache License 2.0

464 stars 102 forks source link

Add `include_data_types` argument to `generate_model_yaml` macro #122

Closed linbug closed 11 months ago

linbug commented 1 year ago

resolves dbt-labs/dbt-core#120

Also:

updates the default include_data_types value for generate_source to True
lowers returned data types for generate_source and generate_model_yaml

This is a:

[ ] documentation update
[ ] bug fix with no breaking changes
[x] new functionality
[x] a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Checklist

[x] This code is associated with an issue which has been triaged and accepted for development.
[x] I have verified that these changes work locally
[x] I have updated the README.md (if applicable)
[x] I have added tests & descriptions to my models (and macros if applicable)
[x] I have added an entry to CHANGELOG.md

xrpza commented 1 year ago

Are you looking for additional contributors on this to help keep it moving? Happy to help however I can but obviously don't want to inject myself where I shouldn't.

dave-connors-3 commented 1 year ago

@linbug -- this looks great -- if you are able to resolve the conflicts, we can do a final review and release on this!

jenna-jordan commented 1 year ago

@linbug -- this looks great -- if you are able to resolve the conflicts, we can do a final review and release on this!

Jumping in as someone who has been watching the PR for over a month now - I'm so excited that this is finally going to be merged in! This is a feature I've been waiting for before our team implements contracts, thank you all so much for working on this!

thomas-vl commented 1 year ago

@linbug do you need any help getting this PR over the finish line? If you don't have time I would love to help!

dbeatty10 commented 1 year ago

I'm going to take a shot at resolving the merge conflicts and then do final review.

gwenwindflower commented 1 year ago

@dbeatty10 you are a champion of life

thomas-vl commented 1 year ago

I'm going to take a shot at resolving the merge conflicts and then do final review.

Let me know if you need help.

linbug commented 11 months ago

Apologies for missing the pings about resolving conflicts. Thank you for merging this!

dbeatty10 commented 11 months ago

No prob @linbug -- really appreciate the great work you did here! 🏆