dbt-labs / dbt-codegen

Macros that generate dbt code
https://hub.getdbt.com/dbt-labs/codegen/latest/
Apache License 2.0
459 stars 99 forks source link

Include secure views in generate_source macro (via get_relations_by_pattern macro) #150

Closed adinsmoor closed 2 months ago

adinsmoor commented 8 months ago

Describe the feature

Customer using the generate_source macro noticed that it was not picking up secure views in Snowflake. After a look through the macro logic, it traces back to the get_relations_by_pattern macro here: https://github.com/dbt-labs/dbt-utils/blob/main/macros/sql/get_relations_by_pattern.sql

Is this intended to only pick up tables? The name suggests it might also include views, but the code looks like it just grabs tables, so I'm submitting a note here to flag.

github-actions[bot] commented 2 months ago

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

github-actions[bot] commented 2 months ago

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.