Escape upstream descriptions in generate_model_yaml - Githubissues

dbt-labs / dbt-codegen

Macros that generate dbt code

https://hub.getdbt.com/dbt-labs/codegen/latest/

Apache License 2.0

459 stars 99 forks source link

Escape upstream descriptions in generate_model_yaml #159

Closed wircho closed 6 months ago

wircho commented 6 months ago

resolves #142

This is a:

[ ] documentation update
[x] bug fix with no breaking changes
[ ] new functionality
[ ] a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

JSON-escapes upstream descriptions before inserting them in the YAML in generate_model_yaml.

Checklist

[ ] This code is associated with an issue which has been triaged and accepted for development.
[ ] I have verified that these changes work locally
[x] ~I have updated the README.md (if applicable)~
[x] I have added tests & descriptions to my models (and macros if applicable)
[x] I have added an entry to CHANGELOG.md

gwenwindflower commented 6 months ago

Had to add some unrelated commits to get the test suite working, nothing to do with your code, it was broken before. LGTM now though and all tests are passing, merging in!