Closed pnadolny13 closed 4 months ago
awesome work @pnadolny13! this looks great. :shipit:
qq: i recently rewrote the README for contribution, how did that land with you? not sure if you'd already contributed to packages before, so perhaps you didn't need it/read it, but if you did, would love any feedback on any areas that might have been confusing or could be expanded. thanks!
@gwenwindflower the docs were great!
I didnt have any issues getting the tests set up and running other than that the cimg/postgres:9.6
image in the docker compose was amd and my machine expected an arm image. I updated it to the latest cimg/postgres:15.6
and it all worked.
ah awesome thanks @pnadolny13 -- i'll take a look at that i'm sure it's a quite old part of the coedebase that probably hasn't been updated in years, we definitely should probably update to a more recent postgres by default!
@gwenwindflower and @pnadolny13 thanks for pushing this through! I hope I can get back to more dbt work soon and actually benefit from it!
Hi @gwenwindflower , would you mind to release a new version with this improvement please ?
I was also looking for that feature 👍
Regards,
PS: thanks @jgillies !
resolves https://github.com/dbt-labs/dbt-codegen/issues/112
This builds off of and should replace https://github.com/dbt-labs/dbt-codegen/pull/136. I didnt know how to continue working off @jgillies 's fork so I made my own. In comparison to that existing PR this adds:
This is a:
All pull requests from community contributors should target the
main
branch (default).Description & motivation
Checklist
Notes: