Case sensitive generate source

pnadolny13 commented 4 months ago

resolves https://github.com/dbt-labs/dbt-codegen/issues/112

This builds off of and should replace https://github.com/dbt-labs/dbt-codegen/pull/136. I didnt know how to continue working off @jgillies 's fork so I made my own. In comparison to that existing PR this adds:

database and schema case sensitive options
an integration test to assert the changes

This is a:

[ ] documentation update
[ ] bug fix with no breaking changes
[x] new functionality
[ ] a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Checklist

[x] This code is associated with an issue which has been triaged and accepted for development.
[x] I have verified that these changes work locally
[x] I have updated the README.md (if applicable)
[x] I have added tests & descriptions to my models (and macros if applicable)
[x] I have added an entry to CHANGELOG.md

Notes:

I dont know of a way to test database casing in the current testing set up. Let me know if theres a way to do that! cc @gwenwindflower

gwenwindflower commented 4 months ago

awesome work @pnadolny13! this looks great. :shipit:

qq: i recently rewrote the README for contribution, how did that land with you? not sure if you'd already contributed to packages before, so perhaps you didn't need it/read it, but if you did, would love any feedback on any areas that might have been confusing or could be expanded. thanks!

pnadolny13 commented 4 months ago

@gwenwindflower the docs were great!

I didnt have any issues getting the tests set up and running other than that the cimg/postgres:9.6 image in the docker compose was amd and my machine expected an arm image. I updated it to the latest cimg/postgres:15.6 and it all worked.

gwenwindflower commented 4 months ago

ah awesome thanks @pnadolny13 -- i'll take a look at that i'm sure it's a quite old part of the coedebase that probably hasn't been updated in years, we definitely should probably update to a more recent postgres by default!

jgillies commented 4 months ago

@gwenwindflower and @pnadolny13 thanks for pushing this through! I hope I can get back to more dbt work soon and actually benefit from it!

mickaelandrieu commented 4 months ago

Hi @gwenwindflower , would you mind to release a new version with this improvement please ?

I was also looking for that feature 👍

Regards,

PS: thanks @jgillies !

dbt-labs / dbt-codegen

Case sensitive generate source #168

Description & motivation

Checklist