dbt-labs / dbt-codegen

Macros that generate dbt code
https://hub.getdbt.com/dbt-labs/codegen/latest/
Apache License 2.0
459 stars 99 forks source link

Update Changelog #174

Closed gwenwindflower closed 2 months ago

pnadolny13 commented 3 months ago

@gwenwindflower is it possible to get this merged with a release? To have https://github.com/dbt-labs/dbt-codegen/pull/168 supported without pinning to a git branch 😄 . I'm happy to help with anything needed to get it across the finish line!

gwenwindflower commented 2 months ago

@pnadolny13 huge apologies! i had some health issues crop up and was out of office for a bit, and it's taking me some time to get fully recalibrated. i'm going to block out time Monday and Tuesday to catch up all the codegen things. Appreciate you!

pnadolny13 commented 2 months ago

huge apologies! i had some health issues crop up and was out of office for a bit, and it's taking me some time to get fully recalibrated

No worries! Sorry to hear that, I hope everything is ok. Let me know if theres anything I can help with 😄

gwenwindflower commented 2 months ago

@pnadolny13 so i've tried a bunch of ways both before i went on medical leave and recently to get testing working for case sensitivity across all the warehouses and it just seems to be technically infeasible right now.

as such, i'm just removing testing and going to ship a beta release of case sensitivity without tests. if that seems to be okay after a month or so we'll just cut that as a regular release and keep going.

there's an issue that needs to be fixed in dbt Core to make testing possible for this, which is essentially we need for dbt to preserve case sensitivity in seeds, which it does not right now. at present if you have a CasEd SeEd dbt will default to the warehouse's default casing UPPER or lower, etc. So we're unable to seed the testing data reliably across adapters. C'est la vie, we shall beta it for now and it should be okay.

gwenwindflower commented 2 months ago

@pnadolny13 please try out codegen 0.13.0-b1 and let me know it goes!