dbt-labs / dbt-codegen

Macros that generate dbt code
https://hub.getdbt.com/dbt-labs/codegen/latest/
Apache License 2.0
484 stars 106 forks source link

Add source description #40

Closed djbelknapdbs closed 3 years ago

djbelknapdbs commented 3 years ago

Description & motivation

Add the placeholder for description to sources requested in #17 and #28 .

Checklist

clrcrl commented 3 years ago

Hi @djbelknapdbs — thanks so much for this PR!

The tests are failing because of an unrelated issue (one that we fixed in #39). To get past this issue, try rebasing (or merging in) the latest changes

Once that's fixed, I think you'll also find that the existing integration tests start failing — we have logic that is not expecting these description keys

Finally, once we have passing code, I think we'd want to implement this as an argument, e.g. include_descriptions=True (with a default value of False(

So there's a fair bit to do:

Let me know if you're up for this, or if all that feels like too much work (a totally reasonable response!)

djbelknapdbs commented 3 years ago

Hi @clrcrl - thanks for the review. I'm just getting going on contributing and the testing part in particular. I think I got these issues squared away. I hijacked an existing test since it referred to all args, but if you'd rather it's a new test I can do that too.