dbt-labs / dbt-codegen

Macros that generate dbt code
https://hub.getdbt.com/dbt-labs/codegen/latest/
Apache License 2.0
464 stars 102 forks source link

Feature/generate multiple models yaml #85

Closed angelica-lastra closed 1 year ago

angelica-lastra commented 1 year ago

This is a:

Description & motivation

closes #68 Added code that allows for generate_model_yaml to accept multiple model arguments as a list, or one model as a string. Updated README to reflect this feature.

Checklist

Other comments

bennieregenold7 commented 1 year ago

@angelica-lastra I think there may be something off between this and the branch you're merging into. There are 32 changed files, but if I remember correctly, you only changed one. Should this merge into dev/0.4.0 or main?

angelica-lastra commented 1 year ago

@bennieregenold7 I think you are right, I got confused because the checklist on the PR said "[x] new functionality — please ensure the base branch is the latest dev/ branch", so I assumed I had to merge there, but main made more sense to me.

angelica-lastra commented 1 year ago

@bennieregenold7 I changed to merge to main and that seemed to address that concern, however, if anyone else has any guidance on this, please let me know!

angelica-lastra commented 1 year ago

Awesome work here! Especially love the way you dealt with appending the single model name to an empty list if it's inputed as a string. LGTM!

@graciegoheen Thank you so much! I am so excited I have not stopped thinking about this! that particular code you are referring to is all thanks to @bennieregenold7 for catching it and walking me through how to write it!

joellabes commented 1 year ago

hurrah! congrats @angelica-lastra 🎉