added comments to verbose regex in generate_model_import_ctes - Githubissues

dbt-labs / dbt-codegen

Macros that generate dbt code

https://hub.getdbt.com/dbt-labs/codegen/latest/

Apache License 2.0

480 stars 106 forks source link

added comments to verbose regex in generate_model_import_ctes #93

Closed graciegoheen closed 1 year ago

graciegoheen commented 1 year ago

This is a:

[x] bug fix PR with no breaking changes — please ensure the base branch is main
[ ] new functionality — please ensure the base branch is the latest dev/ branch
[ ] a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Closes #91 - increases readability of generate_model_import_ctes.sql by using VERBOSE mode for regex and explanatory comments

Checklist

[x] I have verified that these changes work locally
[ ] I have updated the README.md (if applicable)
[ ] I have added tests & descriptions to my models (and macros if applicable)
[ ] I have added an entry to CHANGELOG.md

joellabes commented 1 year ago

Blessings upon you ❤️

leverage those regexes in other context

If this becomes necessary, please consider turning them into get_XXXX_regex() macros instead of copy-pasting them around.