FEATURE- Add logic in generate_source macro to generate nested …

dbt-labs / dbt-codegen

Macros that generate dbt code

https://hub.getdbt.com/dbt-labs/codegen/latest/

Apache License 2.0

464 stars 102 forks source link

FEATURE- Add logic in generate_source macro to generate nested … #97

Closed charles-astrafy closed 1 year ago

charles-astrafy commented 1 year ago

This is a:

[ ] bug fix PR with no breaking changes — please ensure the base branch is main
[X] new functionality — please ensure the base branch is the latest dev/ branch
[ ] a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Checklist

[X] I have verified that these changes work locally
[X] I have updated the README.md (if applicable)
[X] I have added tests & descriptions to my models (and macros if applicable)
[] I have added an entry to CHANGELOG.md

charles-astrafy commented 1 year ago

Thank you @dbeatty10 for this detailed review. I will complete the six points you require in the course of this week and I will open a new PR against the "main" branch.

And fully agreed to create a function to keep code DRY between the code used from generate_column_yamlfor models and sources. I will do something around a function that takes indentation as a parameter in order to handle different levels of indentations.

github-actions[bot] commented 1 year ago

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] commented 1 year ago

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.