dbt-labs / dbt-common

Apache License 2.0
13 stars 15 forks source link

Create a print Event to replace the print usage in dbt-core #130

Closed ChenyuLInx closed 6 months ago

ChenyuLInx commented 6 months ago

related to https://github.com/dbt-labs/dbt-core/issues/8756

Related PR https://github.com/dbt-labs/dbt-core/pull/10131

Description

We want to have some event that

Checklist

github-actions[bot] commented 6 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 28.57143% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 56.66%. Comparing base (3b61b6f) to head (24a7b7d). Report is 1 commits behind head on main.

Files Patch % Lines
dbt_common/events/types_pb2.py 10.90% 49 Missing :warning:
dbt_common/events/logger.py 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #130 +/- ## ========================================== + Coverage 56.37% 56.66% +0.28% ========================================== Files 50 50 Lines 3090 3106 +16 ========================================== + Hits 1742 1760 +18 + Misses 1348 1346 -2 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/130/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `56.66% <28.57%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.