dbt-labs / dbt-common

Apache License 2.0
13 stars 15 forks source link

Use fastjsonschema instead of jsonschema for validation #146

Open gshank opened 5 months ago

gshank commented 5 months ago

resolves #145

Description

For performance reasons we are replacing jsonschema with fastjsonschema.

Checklist

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.78%. Comparing base (bef3b7d) to head (fdecf8c).

Files Patch % Lines
dbt_common/dataclass_schema.py 96.00% 1 Missing :warning:
dbt_common/exceptions/base.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #146 +/- ## ========================================== + Coverage 64.33% 64.78% +0.45% ========================================== Files 51 51 Lines 3230 3243 +13 ========================================== + Hits 2078 2101 +23 + Misses 1152 1142 -10 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/146/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/146/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `64.78% <92.30%> (+0.45%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.