dbt-labs / dbt-common

Apache License 2.0
10 stars 15 forks source link

Deserialize records "just in time" in order to avoid import order isssue #151

Closed peterallenwebb closed 4 months ago

peterallenwebb commented 4 months ago

resolves CORE-308

Description

Because not all Record types may not be imported when a recording is loaded, defer deserialization until they are requested, at which time they are guaranteed to be available.

Checklist

github-actions[bot] commented 4 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.30%. Comparing base (dbb2308) to head (9fe6746).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #151 +/- ## ======================================= Coverage 64.30% 64.30% ======================================= Files 51 51 Lines 3202 3202 ======================================= Hits 2059 2059 Misses 1143 1143 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/151/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/151/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `64.30% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.