dbt-labs / dbt-common

Apache License 2.0
13 stars 15 forks source link

add to and to_column(s) to ColumnLevelConstraint and ModelLevelConstraint contracts #163

Closed MichelleArk closed 4 months ago

MichelleArk commented 4 months ago

resolves https://github.com/dbt-labs/dbt-common/issues/168

Description

as part of https://github.com/dbt-labs/dbt-core/issues/8062, we will need to extend these contracts to optionally include to and to_columns fields.

Checklist

github-actions[bot] commented 4 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (71f4d53) to head (d516a4e).

Files Patch % Lines
dbt_common/contracts/constraints.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #163 +/- ## ========================================== - Coverage 64.34% 64.31% -0.04% ========================================== Files 51 51 Lines 3223 3225 +2 ========================================== Hits 2074 2074 - Misses 1149 1151 +2 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/163/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/163/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `64.31% <0.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.