dbt-labs / dbt-common

Apache License 2.0
13 stars 15 forks source link

Fix case-insensitive env vars for Windows #166

Closed aranke closed 4 months ago

aranke commented 4 months ago

Description

Add a new CaseInsensitiveMapping class and use that for env vars on Windows. Add a test to verify this case-insensitive mapping.

Checklist

github-actions[bot] commented 4 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

github-actions[bot] commented 4 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.34%. Comparing base (6e3828e) to head (16f61ba).

Files Patch % Lines
dbt_common/context.py 73.91% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #166 +/- ## ========================================== + Coverage 64.31% 64.34% +0.03% ========================================== Files 51 51 Lines 3203 3223 +20 ========================================== + Hits 2060 2074 +14 - Misses 1143 1149 +6 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/166/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `64.34% <73.91%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.