dbt-labs / dbt-common

Apache License 2.0
13 stars 15 forks source link

Add group property to records. Correct filter on file records. #169

Closed peterallenwebb closed 4 months ago

peterallenwebb commented 4 months ago

resolves #

Description

This PR adds a "group" property to records that can be used to record, replay, or diff related records. The initial application of the group property will be to create a Database group in core and adapters which will apply to all records related to DB/DWH interaction.

Checklist

github-actions[bot] commented 4 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (8edae92) to head (a54fa57).

Files Patch % Lines
dbt_common/clients/system.py 20.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #169 +/- ## ======================================= Coverage 64.31% 64.31% ======================================= Files 51 51 Lines 3225 3228 +3 ======================================= + Hits 2074 2076 +2 - Misses 1151 1152 +1 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/169/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/169/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `64.31% <50.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.