dbt-labs / dbt-common

Apache License 2.0
13 stars 15 forks source link

Add "object" mergebehavior to MergeBehavior processing #192

Closed gshank closed 2 months ago

gshank commented 2 months ago

resolves #191

Description

Add a new type of MergeBehavior, "Object". Move the processing of config_call_dicts to the same file. Create tests for both types of merges.

Checklist

github-actions[bot] commented 2 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.33%. Comparing base (9798ca7) to head (72506cb).

Files with missing lines Patch % Lines
dbt_common/contracts/config/base.py 66.66% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #192 +/- ## ========================================== + Coverage 65.16% 67.33% +2.17% ========================================== Files 52 52 Lines 3333 3380 +47 ========================================== + Hits 2172 2276 +104 + Misses 1161 1104 -57 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/192/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dbt-labs/dbt-common/pull/192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `67.33% <66.66%> (+2.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.