dbt-labs / dbt-core

dbt enables data analysts and engineers to transform their data using the same practices that software engineers use to build applications.
https://getdbt.com
Apache License 2.0
9.68k stars 1.61k forks source link

update on_skip to adjust for node that do not have schema #10302

Closed ChenyuLInx closed 3 months ago

ChenyuLInx commented 3 months ago

resolves #10029

Problem

SavedQuery node do not have schema field, this cause on_skip to fail.

Solution

During the on skip, we optionally get schema field. The other way is to add schema to the saved_query node, but that is not a useful piece of information for this node.

Checklist

github-actions[bot] commented 3 months ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.69%. Comparing base (e699f5d) to head (d303bee).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10302 +/- ## ======================================= Coverage 88.69% 88.69% ======================================= Files 180 180 Lines 22483 22483 ======================================= Hits 19942 19942 Misses 2541 2541 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10302/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10302/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `85.95% <100.00%> (ø)` | | | [unit](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10302/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `61.78% <100.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.