dbt-labs / dbt-core

dbt enables data analysts and engineers to transform their data using the same practices that software engineers use to build applications.
https://getdbt.com
Apache License 2.0
9.25k stars 1.53k forks source link

Remove unnecessary IntermediateSnapshotNode and EmptySnapshotConfig #10332

Closed gshank closed 1 week ago

gshank commented 1 week ago

resolves #10326

Problem

We no longer need the IntermediateSnapshotNode and EmptySnapshotConfig classes, or the IntermediateNode typevar.

Solution

Remove them.

Checklist

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.78%. Comparing base (71a8a41) to head (7853431).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10332 +/- ## ========================================== - Coverage 88.83% 88.78% -0.06% ========================================== Files 180 180 Lines 22490 22479 -11 ========================================== - Hits 19980 19958 -22 - Misses 2510 2521 +11 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10332/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `86.08% <100.00%> (-0.11%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `62.17% <100.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.