dbt-labs / dbt-core

dbt enables data analysts and engineers to transform their data using the same practices that software engineers use to build applications.
https://getdbt.com
Apache License 2.0
9.25k stars 1.53k forks source link

[Tidy first] move non-circular import to top of manifest.py #10333

Closed MichelleArk closed 1 week ago

MichelleArk commented 1 week ago

resolves #N/A

Problem

Nested import assuming a cycle

Solution

Move import to top of file since there is no cycle!

Checklist

github-actions[bot] commented 1 week ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.83%. Comparing base (71a8a41) to head (fa6e0ef).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10333 +/- ## ======================================= Coverage 88.83% 88.83% ======================================= Files 180 180 Lines 22490 22490 ======================================= Hits 19980 19980 Misses 2510 2510 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10333/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `86.21% <100.00%> (+0.02%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `62.19% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.