dbt-labs / dbt-core

dbt enables data analysts and engineers to transform their data using the same practices that software engineers use to build applications.
https://getdbt.com
Apache License 2.0
9.25k stars 1.53k forks source link

[Backport 1.7.latest] Add most recent dbt-docs changes #10335

Closed aranke closed 1 week ago

aranke commented 1 week ago

Backport https://github.com/dbt-labs/dbt-core/commit/8ee8b2560a1ff05f2451855cc6c9c93aa6388309 from https://github.com/dbt-labs/dbt-core/pull/10307.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.71%. Comparing base (d96a927) to head (2c2c145).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.7.latest #10335 +/- ## ============================================== - Coverage 86.74% 86.71% -0.03% ============================================== Files 179 179 Lines 26724 26724 ============================================== - Hits 23183 23175 -8 - Misses 3541 3549 +8 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10335/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `83.59% <ø> (-0.07%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10335/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `65.09% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MichelleArk commented 1 week ago

Was able to tophat this locally with postgres 🎩 (be extra careful setting up a fresh environment here (no dbt-adapters or dbt-common)

~/src/dbt-core backport-10307-to-1.7.latest ❯❯ git checkout backport-10307-to-1.7.latest
Switched to branch 'backport-10307-to-1.7.latest'
Your branch is up to date with 'origin/backport-10307-to-1.7.latest'.

❯ cd ../jaffle-shop

~/src/jaffle-shop main* ❯❯ dbt --version
Core:
  - installed: 1.7.16
  - latest:    1.8.2  - Update available!

  Your version of dbt-core is out of date!
  You can find instructions for upgrading here:
  https://docs.getdbt.com/docs/installation

Plugins:

~/src/jaffle-shop main* ❯❯ dbt docs generate
15:39:01  Running with dbt=1.7.16
15:39:01  target not specified in profile 'postgres', using 'default'
15:39:01  Registered adapter: postgres=1.7.16
15:39:01  Unable to do partial parsing because of a version mismatch
15:39:02  The configured adapter does not support metadata-based freshness. A loaded_at_field must be specified for source 'ecom'.
15:39:02  The configured adapter does not support metadata-based freshness. A loaded_at_field must be specified for source 'ecom'.
15:39:02  The configured adapter does not support metadata-based freshness. A loaded_at_field must be specified for source 'ecom'.
15:39:02  The configured adapter does not support metadata-based freshness. A loaded_at_field must be specified for source 'ecom'.
15:39:03  Found 18 models, 6 seeds, 20 tests, 6 sources, 0 exposures, 13 metrics, 699 macros, 0 groups, 6 semantic models
15:39:03
15:39:03  Concurrency: 1 threads (target='default')
15:39:03
15:39:03  Building catalog
15:39:03  Catalog written to /Users/michelleark/src/jaffle-shop/target/catalog.json

~/src/jaffle-shop main* ❯❯ dbt docs serve
15:39:07  Running with dbt=1.7.16
15:39:07  target not specified in profile 'postgres', using 'default'
Serving docs at 8080
To access from your browser, navigate to: http://localhost:8080

Press Ctrl+C to exit.
127.0.0.1 - - [20/Jun/2024 11:39:07] "GET / HTTP/1.1" 200 -
127.0.0.1 - - [20/Jun/2024 11:39:07] "GET /manifest.json?cb=1718897947801 HTTP/1.1" 200 -
127.0.0.1 - - [20/Jun/2024 11:39:07] "GET /catalog.json?cb=1718897947801 HTTP/1.1" 200 -

poked around the UI, no warnings / errors + link to graph viz screenshot:

Screenshot 2024-06-20 at 11 39 17 AM