dbt-labs / dbt-core

dbt enables data analysts and engineers to transform their data using the same practices that software engineers use to build applications.
https://getdbt.com
Apache License 2.0
9.25k stars 1.53k forks source link

pin versions so CI and local dev match #10358

Closed emmyoop closed 4 days ago

emmyoop commented 4 days ago

resolves #

Problem

Requirements for pre-commit hooks were unpinned in dev-requirements.txt resulting in differences for local development and CI.

Solution

Pin the requirements in dev-requirements so that local development matches CI.

Bump isort because there was no breaking change.

black breaks and requires other code changes for major version 24 so I left the pin as is for now flake8 also finds more problems on 1.10 so left that as well

Checklist

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.75%. Comparing base (2bae05b) to head (afe0430).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10358 +/- ## ========================================== - Coverage 88.81% 88.75% -0.06% ========================================== Files 180 180 Lines 22486 22486 ========================================== - Hits 19970 19957 -13 - Misses 2516 2529 +13 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10358/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `86.01% <ø> (-0.14%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `62.19% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10358/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [Unit Tests](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10358/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `62.19% <ø> (ø)` | | | [Integration Tests](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10358/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `86.01% <ø> (-0.14%)` | :arrow_down: |