Add flags from dbt_project.yml to the Project and RuntimeConfig objects

mikealfare commented 1 month ago

Resolves #10618

Problem

We need to pass project flags from dbt_project.yml into the BaseAdapter instantiation to support behavior flags. Without this, users cannot override a behavior flag.

Solution

add flags as an attribute on Project, which then adds it to RuntimeConfig
pull the flags from dbt_project.yml::flags, not the global flags
- the flags we're currently looking for are not expected to be overwritten by CLI args or environment variables
ensure existing tests pass
add tests that ensure RuntimeConfig contains arbitrary flags added in dbt_project.yml::flags

Checklist

[x] I have read the contributing guide and understand what's expected of me.
[x] I have run this code in development, and it appears to resolve the stated issue.
[x] This PR includes tests, or tests are not required or relevant for this PR.
[x] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
[x] This PR includes type annotations for new and modified functions.

github-actions[bot] commented 1 month ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.91%. Comparing base (2218140) to head (cc628f2). Report is 21 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #10644 +/- ## ========================================== + Coverage 88.86% 88.91% +0.04% ========================================== Files 180 180 Lines 22762 22799 +37 ========================================== + Hits 20228 20272 +44 + Misses 2534 2527 -7 ``` | [Flag](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10644/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10644/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `86.16% <100.00%> (+0.05%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10644/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `62.36% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10644/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | Coverage Δ | | |---|---|---| | [Unit Tests](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10644/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `62.36% <100.00%> (+0.03%)` | :arrow_up: | | [Integration Tests](https://app.codecov.io/gh/dbt-labs/dbt-core/pull/10644/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbt-labs) | `86.16% <100.00%> (+0.05%)` | :arrow_up: |

github-actions[bot] commented 1 week ago

The backport to 1.8.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-10644-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1d3d315249c81dbca70452e5a14fbfd0edad6b2a
# Push it to GitHub
git push --set-upstream origin backport-10644-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest

Then, create a pull request where the base branch is 1.8.latest and the compare/head branch is backport-10644-to-1.8.latest.

dbt-labs / dbt-core