Closed tsturge closed 1 week ago
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.
In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.
CLA has not been signed by users: @tsturge
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.
Attention: Patch coverage is 71.42857%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 89.13%. Comparing base (
dd77210
) to head (56f2300
). Report is 11 commits behind head on main.
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.
In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.
CLA has not been signed by users: @tsturge
I like this. Especially because the unit tests are now broken when we have ctx like vars inside the model. The way I was handling this was by commenting them out.
Support config: disabled for unit tests. (#9109)
Also, when a model is disabled, disable the corresponding unit tests automatically. (#10540)
Problem
config: enabled: false
Solution
Check for the config: enabled variable while parsing the unit test. If it is set to false, mark the unit test as disabled.
Checklist