dbt-labs / dbt-docs

Auto-generated data documentation site for dbt projects
Apache License 2.0
141 stars 75 forks source link

[CT-1452] Support mermaid in markdown #338

Closed il-dat closed 11 months ago

il-dat commented 2 years ago

Describe the feature

I have seen many places where mermaid can rich the documentation very well. That's why I've tried to utilize it within dbt project, but it doesn't work yet.

Additional context

Who will this benefit?

jtcohen6 commented 1 year ago

Agree that this would be cool! It's unlikely something that we'll be prioritizing ourselves in the near future, given our ongoing commitment to dbt-docs right now can only be parity + stability. But perhaps as a hackathon project for someone interested??

dbt-docs is still written in Angular (!). After a quick search, it looks like there are some resources online for how to integrate the two. Ideal UX here would be the ability to add code blocks with ```mermaid, just like in GitHub Markdown.

We'd need to ensure that this is copacetic from a security standpoint. It looks like there have been some issues in the past (https://security.snyk.io/vuln/SNYK-JS-MERMAID-174698), but also that the team behind mermaid is serious about resolving these.

I've also heard some votes in favor of https://github.com/plantuml/plantuml, as a preferable text-to-visual framework for graphs. It sounds like Mermaid might be easier to write, but PlantUML has been around longer, it's more feature-rich, and it has fewer limitations around the edges.

I'm going to call this help_wanted, if anyone wants to give it a spin!

github-actions[bot] commented 12 months ago

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

github-actions[bot] commented 11 months ago

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

matthieucan commented 10 months ago

I believe this should be reopened, there is a PR adding mermaid.js support for which maintainers' attention would be really appreciated