dbt-labs / dbt-docs

Auto-generated data documentation site for dbt projects
Apache License 2.0
141 stars 75 forks source link

fix bug dbt docs, having a folder with the same name as a macro breaks dbt docs #443

Closed etnnth closed 1 week ago

etnnth commented 1 year ago

resolves #442

Description

Fix bug where the docs site crashed when a macro and a folder had the same name. This was due a a key collision in the tree object that was used to create the project structure. The fix is to change the key to be sure that they cannot be identical.

Checklist

etnnth commented 1 year ago

@dbeatty10 do I need to do something else to help getting this fix merged?

github-actions[bot] commented 6 months ago

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] commented 6 months ago

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

dbeatty10 commented 6 months ago

@etnnth -- sorry this got closed as stale. I'm going to re-open it in hopes we can do an initial code review on it.

github-actions[bot] commented 2 weeks ago

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] commented 1 week ago

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.