dbt-labs / dbt-docs

Auto-generated data documentation site for dbt projects
Apache License 2.0
139 stars 74 forks source link

add semantic models #444

Closed emmyoop closed 1 year ago

emmyoop commented 1 year ago

resolves #431

Description

Checklist

github-actions[bot] commented 1 year ago

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

emmyoop commented 1 year ago

Metrics Page - depends on a semantic model Screenshot 2023-08-07 at 3 28 23 PM

Semantic Model Page with new Project nav on left Screenshot 2023-08-07 at 3 26 34 PM

condensed DAG model -> semantic model -> metric Screenshot 2023-08-07 at 3 26 46 PM

full screen view of above Screenshot 2023-08-07 at 3 27 05 PM

emmyoop commented 1 year ago

A few observations:

  1. semantic models don't have labels so there is no "friendly name" to display. Used node.name instead.

Open Questions

  1. Is there some kind of code to display? Metrics used to display the generated sql but dbt docs is failing on that. Wasn't sure if it's not possible or if I missed something.
  2. Would you prefer a different color for semantic models?
  3. Should other fields be displayed for semantic models? The above is a copy of the metric node page.
emmyoop commented 1 year ago

Added entities Screenshot 2023-08-08 at 10 58 41 AM