dbt-labs / dbt-external-tables

dbt macros to stage external sources
https://hub.getdbt.com/dbt-labs/dbt_external_tables/latest/
Apache License 2.0
297 stars 119 forks source link

Add support for Trino #153

Closed cbhagl closed 1 year ago

cbhagl commented 2 years ago

Description & motivation

This PR adds support for Trino (using the Hive connector).

I have tested things on my local setup and tried my best to add relevant configuration for integration tests (I copied a lot from #133). For the integration tests to work, there should be an S3 bucket called test_bucket, a Trino instance configured with the Hive connector and access to said S3 bucket (see docs). I excluded JSON tests as I have little experience with Hive external JSON tables.

The following environment variables should be set to be able access Trino in CI:

I will gladly assist any effort to get the integration tests running and improve this plugin.

Checklist

github-actions[bot] commented 1 year ago

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] commented 1 year ago

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.